[sl] bump macOS python CI to 3.11.3 #605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We still depend on pointing to the specific Python combination that GitHub CI and Homebrew have, which currently is 3.11.3. Hashes were taken from https://github.com/Homebrew/homebrew-core/blob/d39875e2128e83333aa12728b715fd932c52a1f4/Formula/python@3.11.rb Test plan: CI
|
@sggutier has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
Summary: [sl] fix compatibility with PEP 440 Our current versioning schema isn't compatible with PEP 440. Luckily, changing the last `-` to a `+` works. Credit for the idea goes to ZhongRuoyu as mentioned in #598 Pull Request resolved: #606 Test Plan: - Ran `sl --version` to verify that it outputted a sane format (got `Sapling 0.2.20230417-165855+6db1e950`) - Verified that this was compliant with PEP 440: https://regex101.com/r/sv6aUZ/1 - Verified that this was compliant with Semver 2.0: https://regex101.com/r/RQsynA/1 - Also, verified that this was still compatible with Homebrew in a similar way to D42006425: ``` $ git --no-pager diff diff --git a/Library/Homebrew/test/version_spec.rb b/Library/Homebrew/test/version_spec.rb index 647fb5dcc..ac35b920a 100644 --- a/Library/Homebrew/test/version_spec.rb +++ b/Library/Homebrew/test/version_spec.rb @@ -841,6 +841,12 @@ describe Version do .to be_detected_from("https://opam.ocaml.org/archives/easy-format.1.0.2+opam.tar.gz") end + specify "sapling-better" do + expect(described_class.create("0.2.20230417-165855")) + .to be_detected_from("https://github.com/facebook/sapling/archive/refs/tags/0.2.20230417-165855+6db1e950.tar.gz") + end + + specify "no extension version" do expect(described_class.create("1.8.12")) .to be_detected_from("https://waf.io/waf-1.8.12") % ``` ``` $ ./bin/brew tests --only version -d -v Randomized with seed 48812 bundle exec parallel_rspec --nice -- -I /Users/sggutier/homebrew/Library/Homebrew/test --seed 48812 --color --require spec_helper --tag ~needs_linux --tag ~needs_network --tag ~needs_ci --tag ~needs_svn -- test/version_spec.rb test/version/parser_spec.rb 2 processes for 2 specs, ~ 1 spec per process ................... ..................................................................................................................... Took 2 seconds ``` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/606). * __->__ #606 * #605 Reviewed By: zzl0 Differential Revision: D45072716 Pulled By: sggutier fbshipit-source-id: 6fea731486e8b7ea4606a96b064dc3f724420649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sl] bump macOS python CI to 3.11.3
Summary:
We still depend on pointing to the specific Python combination that GitHub CI and Homebrew have, which currently is 3.11.3.
Hashes were taken from https://github.com/Homebrew/homebrew-core/blob/d39875e2128e83333aa12728b715fd932c52a1f4/Formula/python@3.11.rb
Test plan:
CI
Stack created with Sapling. Best reviewed with ReviewStack.