Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function with noexcept specifier throws exception causes program terminated #186

Open
zER0pAGe-1 opened this issue Mar 5, 2021 · 3 comments

Comments

@zER0pAGe-1
Copy link

The following function in wangle acceptor could possibly throws an exception in makeNewAsyncSocket
https://github.com/facebook/wangle/blob/master/wangle/acceptor/Acceptor.cpp#L305

While I didn't find any catch phrase that could handle this exception, thus when create new async socket failed, the exception causes the whole program terminated.

My question is, is that normal or should I override this function to deal with exceptions on my case?

@yfeldblum
Copy link
Contributor

It is not generally expected that creating the async socket fails, triggering program termination.

Do you have more details on what the exception is and what triggers it? If this is reproducible in the debugger, any chance of a type, a message, and a stacktrace?

@zER0pAGe-1
Copy link
Author

Exception message:
AsyncSocketException: failed to set close-on-exec flag(type = Internal error, errno=9(Bad file descriptor))

@zER0pAGe-1
Copy link
Author

Exception happens about once a day (online environment), and it seems I can't reproduce it in debugger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants