This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Make xctool play nice with Find Implicit Dependencies #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods. This `populate` method is getting pretty big - let's refactor it a bit.
…methods. This populate function was getting too long.
…tings. If the original scheme enabled 'parallelizeBuildables' or 'buildImplicitDependencies', then the generated scheme should use them, too.
…s workspace Previously, we only added projects for the buildables and testables to the generated workspace. This was fine, but it doesn't give Xcode's Find Implicit Dependencies feature enough information to work from. Let's make the generated workspace include all the projects. Test Plan: Tests pass. Verified that find implicit dependencies now works with a CocoaPods project.
|
I've just tried this branch on my dummy test project which was created for #16 and it works with implicit dependencies! The only change I was required to do is to set
Thank you @fpotter for your job! 👍 |
|
@yas375 Thanks for verifying! |
|
@fpotter sure! :) |
fpotter
added a commit
that referenced
this pull request
Jul 12, 2013
Make xctool play nice with Find Implicit Dependencies
|
Awesome! |
tomquist
pushed a commit
to tomquist/xctool
that referenced
this pull request
Aug 23, 2013
…cit-dependencies Make xctool play nice with Find Implicit Dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When xctool builds tests, it generates a throwaway workspace and scheme and then calls
xcodebuildon that workspace/scheme.There were 2 problems that prevented implicit dependencies from working --
buildImplicitDependencies = "YES"if the original scheme said to use implicit dependencies.This fixes #62 and #16, and xctool will finally play nice with CocoaPods out of the box.