Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale flex basis value used with cached values #1161

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rozele
Copy link
Contributor

@rozele rozele commented Sep 29, 2022

Summary:
We're occasionally seeing text truncation occur on Windows. It appears to occur when a cached main axis value is supplied to the flex basis computation for children, resulting in a stale flex basis value getting used.

This diff just contributes a unit test that reliably reproduces this case.

Differential Revision: D39929963

Summary:
We're occasionally seeing text truncation occur on Windows. It appears to occur when a cached main axis value is supplied to the flex basis computation for children, resulting in a stale flex basis value getting used.

This diff just contributes a unit test that reliably reproduces this case.

Differential Revision: D39929963

fbshipit-source-id: 5bae1de3f1498dbc45e42a76184d4269e01a12da
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39929963

@jeetiss
Copy link
Contributor

jeetiss commented Mar 6, 2023

I've experienced the same problem with react-pdf and satori

Here is the code sandbox with javascript reproduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants