Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.6 Windows binary downloads are double zipped #4000

Closed
pratikpc opened this issue Mar 29, 2024 · 4 comments
Closed

v1.5.6 Windows binary downloads are double zipped #4000

pratikpc opened this issue Mar 29, 2024 · 4 comments
Assignees

Comments

@pratikpc
Copy link

Describe the bug
v1.5.6 windows binaries are double zipped

To Reproduce
Steps to reproduce the behavior:

  1. Download https://github.com/facebook/zstd/releases/download/v1.5.6/zstd-v1.5.6-win64.zip

Expected behavior
No need for double unzip

Screenshots and charts
NA

Desktop (please complete the following information):
NA

Additional context
NA

@pratikpc
Copy link
Author

It has been reported that Chrome is also blocking their downloads

@lelik107
Copy link

lelik107 commented Mar 29, 2024

Yann's gonna be a pirate :) And the next step will be a password - ZSTD or zstd, obviously. Or he was just too busy with the release. Yes, nowadays, some browsers don't allow this to download.

@Cyan4973 Cyan4973 self-assigned this Mar 29, 2024
@Cyan4973
Copy link
Contributor

This should be fixed now.

Not sure how it happened.
Strangely, there was no problem downloading the zip file myself using Chrome (tested again today, still successful).
Also, testing the archive, the archiver (default macos) directly delivers the final directory of files without any intermediate step, transparently decompressing the 2 layers of zip. That makes is harder to spot (could nonetheless confirm it by using the unzip cli).

@lelik107
Copy link

It's OK now. It might be @ pratikpc mentioned one of the Chromium based browsers we have a lot. I suggest that issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants