This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Bug handling timestamps with different endian-ness #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
png85
added a commit
to png85/RakNet
that referenced
this pull request
Sep 19, 2015
Integrate upstream pull requests facebookarchive#4 facebookarchive#10 facebookarchive#14 facebookarchive#29 facebookarchive#30 facebookarchive#31 facebookarchive#38 various issues.
|
Our review of this pull request suggests this would be an incorrect change. As far as we can see BitStream::Read() already performs the endianess-swapping if required. Therefore this pull request is not integrated in https://github.com/SLikeSoft/SLikeNet . Please let us know if you think this conclusion is incorrect. |
|
Makes sense, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.