This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix possible buffer overrun #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
png85
added a commit
to png85/RakNet
that referenced
this pull request
Sep 19, 2015
Integrate upstream pull requests facebookarchive#4 facebookarchive#10 facebookarchive#14 facebookarchive#29 facebookarchive#30 facebookarchive#31 facebookarchive#38 various issues.
|
Pull request incorporated in SLikeNet 0.1.0. |
rhard
pushed a commit
to rhard/RakNet
that referenced
this pull request
Oct 26, 2017
Add missing read alignment in ReplicaManager3::OnConstruction
Luke1410
reviewed
Jun 2, 2018
| unsigned int lengthsArray[512]; | ||
| const char *dataArray[512]; | ||
| unsigned int lengthsArray[513]; | ||
| const char *dataArray[513]; |
There was a problem hiding this comment.
As @kfsone pointed out in his comment, increasing the array size is unnecessary. See the condition in the for-loop in line 94 which explicitly checks for i < 512 (in addition to i < numParameters). Not a common coding style I'd say (and therefore easily to overlook), but this should prevent any out of bounds access, no?
g-andrade
added a commit
to g-andrade/RakNet
that referenced
this pull request
Oct 14, 2020
…fix_memory_out_of_bounds Feature/fix memory out of bounds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these arrays may be accessed at (1..512) below