This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix 3 memory leaks in AutoPatcher/ApplyPatch.cpp #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change README to markdown format
This commit fixes a mismatching allocation/deallocation of a char array in the AutoPatcher code: CreatePatch.cpp:529: *out = new char[*outSize]; CreatePatch.cpp:579: free(out); Mixing up new/delete and malloc/free is undefined behaviour and should be avoided.
…rflow Fix buffer overflow in chat server example
…ePatch-UB_fix Fix mismatching allocation/deallocation in AutoPatcher/CreatePatch.cpp
This commit fixes three memory leaks in the AutoPatcher code: ApplyPatch.cpp:288: patch = new char[patchSize]; ApplyPatch.cpp:289: old = new char[oldSize]; ApplyPatch.cpp:191: _new = new char[*newSize+1]; These buffers aren't deleted when returning from int TestPatchInMemory(int argc, char*argv[]) at line 300 of the original sources, so (patchSize + oldSize + newSize + 1) bytes of memory are leaked.
|
Changes to DependentExtensions/Autopatcher/ApplyPatch.cpp incorporated in SLikeNet 0.1.0 in a slightly modified way, so there's no double free in case ApplyPatch() already freed _new. |
rhard
pushed a commit
to rhard/RakNet
that referenced
this pull request
Oct 26, 2017
fix RakMemoryOverride
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three memory leaks in the AutoPatcher code:
ApplyPatch.cpp:288: patch = new char[patchSize];
ApplyPatch.cpp:289: old = new char[oldSize];
ApplyPatch.cpp:191: _new = new char[*newSize+1];
These buffers aren't deleted when returning from
int TestPatchInMemory(int argc, char*argv[])
at line 300 of the original sources, so (patchSize + oldSize + newSize + 1)
bytes of memory are leaked.