-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
Hopefully this won't create any problem with goose's parsing of that file |
Bah, this again, sorry. Doesn't the linter run as part of the integ test run in the container? Probably we already discussed this, I forgot what the outcome of this discussion was.
Tested locally and it doesn't interfere with the parsing, anyway the integ test run will exercise the migration so it should confirm. |
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 62.06% 62.14% +0.07%
==========================================
Files 82 82
Lines 3883 3883
==========================================
+ Hits 2410 2413 +3
+ Misses 1186 1183 -3
Partials 287 287
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The public linter ignores non-go files while the internal one doesn't. I can adjust the public linter to include sql, one sec |
Signed-off-by: Andrea Barberio <insomniac@slackware.it>
8c18c3c
to
0141ee0
Compare
Updated, but I have to change the regexp too, to match the sql-style comments, one sec |
Interestingly, it returns success, but it should fail because of the different comment style |
not sure why this is happening, but sounds like a bug in |
will look at that tomorrow |
@marcoguerri if that's OK I will merge this to fix the copyright header, and file an issue for checklicenses |
Sorry for the latency, yes, that's perfectly fine. |
Signed-off-by: Andrea Barberio insomniac@slackware.it