This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is now in pre-review state. Before running a official review, there are a couple of issue are need to be understanding:
This PR tries to fix the previous ignoring inputed logger issue mentioned here:
#56
It did the follows:
test/test_protocol.py
where DNSClientProtocol{UDP,TCP} would be mocked and ensuring that DNSClient passes the logger to them.