Add entire test directory to NPM ignore #120
Conversation
I'd noticed that esprima-fb includes the `test` directory in their NPM package, and it has a bit of weight to it: ``` ➜ test_size git:(master) du -sh ./node_modules/esprima-fb/test 816K ./node_modules/esprima-fb/test ``` In a clean install of EmberJS this is included twice, adding an extra 1.6M to the `node_modules` size. As it's a common package I could see this spanning into multiple more inclusions. Would you consider excluding the `test` directory from the `esprima-fb` package? Thank you for your time in reading!
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
|
|
Ah, makes sense. I'll try and get the repositories depending on it to change over to the original version then. Closing. |
I'd noticed that esprima-fb includes the
testdirectory in their NPM package, and it has a bit of weight to it:In a clean install of EmberJS this is included twice, adding an extra 1.6M to the
node_modulessize. As it's a common package I could see this spanning into multiple more inclusions.Would you consider excluding the
testdirectory from theesprima-fbpackage?Thank you for your time in reading!