Correct reference to FBEHelper in BatchAPI Exception Handler #2
Conversation
|
Hi @danbtl! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@xiangminxufsu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@xiangminxufsu merged this pull request in cf16d61. |
Summary: This corrects an "Undefined Property" error in the exception handler. Pull Request resolved: #2 Reviewed By: zlik Differential Revision: D25455026 Pulled By: xiangminxufsu fbshipit-source-id: cb3d3f76f84fb122d4771a23dedada7a7ef45352
Summary: This is to avoid Magento exception in Stores -> Configuration when the Magento_InventoryApi module is disabled: ``` report.CRITICAL: Error: Cannot instantiate interface Magento\InventoryApi\Api\StockRepositoryInterface in /var/www/html/ego_240/vendor/mag ento/framework/ObjectManager/Factory/AbstractFactory.php:121 Stack trace: #0 /var/www/html/ego_240/vendor/magento/framework/ObjectManager/Factory/Compiled.php(108): Magento\Framework\ObjectManager\Factory\AbstractFactory->createObject() #1 /var/www/html/ego_240/vendor/magento/framework/ObjectManager/ObjectManager.php(70): Magento\Framework\ObjectManager\Factory\Compiled->create() #2 /var/www/html/ego_240/app/code/Facebook/BusinessExtension/Model/Config/Source/Product/InventoryStock.php(46): Magento\Framework\ObjectManager\ObjectManager->get() #3 /var/www/html/ego_240/app/code/Facebook/BusinessExtension/Model/Config/Source/Product/InventoryStock.php(57): Facebook\BusinessExtension\Model\Config\Source\Product\InventoryStock->getStockRepository() #4 /var/www/html/ego_240/vendor/magento/module-eav/Model/Entity/Attribute/Source/AbstractSource.php(168): Facebook\BusinessExtension\Model\Config\Source\Product\InventoryStock->getAllOptions() #5 /var/www/html/ego_240/vendor/magento/module-config/Model/Config/Structure/Element/Field.php(461): Magento\Eav\Model\Entity\Attribute\Source\AbstractSource->toOptionArray() ``` Reviewed By: fbisaso Differential Revision: D32070111 fbshipit-source-id: 103428392bc445e544d1b302a4e49296eba4628b
This corrects an "Undefined Property" error in the exception handler.