Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

Feature Request: Trigger Product Feed Push from Admin #4

Closed
danbtl opened this issue Dec 10, 2020 · 3 comments
Closed

Feature Request: Trigger Product Feed Push from Admin #4

danbtl opened this issue Dec 10, 2020 · 3 comments

Comments

@danbtl
Copy link
Contributor

danbtl commented Dec 10, 2020

It would be helpful to have a button in the admin that can trigger an upload of the whole catalog.

Right now the the feed push is only triggered once during setup.

https://github.com/facebookincubator/facebook-for-magento2/blob/791716e68d9fc685e4f550a4ba67f9fe743481b3/Facebook/BusinessExtension/Controller/Adminhtml/Ajax/Fbfeedpush.php#L33

@zlik
Copy link
Contributor

zlik commented Dec 10, 2020

@danbtl, we're preparing a new version in which this feature as well as some additional improvements are implemented. please stay tune for updates, this should be rolled out very soon ;)

Screen Shot 2020-12-10 at 3 11 46 PM

@danbtl
Copy link
Contributor Author

danbtl commented Dec 10, 2020

@zlik This looks great! Thanks for your quick reply.

@zlik
Copy link
Contributor

zlik commented Mar 5, 2021

This feature was rolled out in v1.2.3.

@zlik zlik closed this as completed Mar 5, 2021
facebook-github-bot pushed a commit that referenced this issue Mar 12, 2021
Summary:
Getting errors on PHP 8:

```
[2021-03-12 00:31:26] FBE.ERROR: Deprecated Functionality: implode(): Passing glue string after array is deprecated. Swap the parameters in /home/magento/magento2/app/code/Facebook/BusinessExtension/Model/Product/Feed/Builder.php on line 365 [] []
"var/log/facebook-business-extension.log" 309L, 45689C                                                                                                                                                                      1,1           Top
#4 /home/magento/magento2/app/code/Facebook/BusinessExtension/Controller/Adminhtml/Ajax/Fbfeedpush.php(47): Facebook\BusinessExtension\Model\Product\Feed\Method\BatchApi->generateProductRequestData()
#5 /home/magento/magento2/app/code/Facebook/BusinessExtension/Controller/Adminhtml/Ajax/AbstractAjax.php(42): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\Fbfeedpush->executeForJson()
#6 /home/magento/magento2/vendor/magento/framework/Interception/Interceptor.php(58): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\AbstractAjax->execute()
#7 /home/magento/magento2/vendor/magento/framework/Interception/Interceptor.php(138): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\Fbfeedpush\Interceptor->___callParent()
#8 /home/magento/magento2/vendor/magento/framework/App/Action/Plugin/ActionFlagNoDispatchPlugin.php(51): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\Fbfeedpush\Interceptor->Magento\Framework\Interception\{closure}()
```

Reviewed By: xiangminxufsu

Differential Revision: D26998474

fbshipit-source-id: e4fe52df
facebook-github-bot pushed a commit that referenced this issue Oct 21, 2022
Summary:
Getting errors on PHP 8:

```
[2021-03-12 00:31:26] FBE.ERROR: Deprecated Functionality: implode(): Passing glue string after array is deprecated. Swap the parameters in /home/magento/magento2/app/code/Facebook/BusinessExtension/Model/Product/Feed/Builder.php on line 365 [] []
"var/log/facebook-business-extension.log" 309L, 45689C                                                                                                                                                                      1,1           Top
#4 /home/magento/magento2/app/code/Facebook/BusinessExtension/Controller/Adminhtml/Ajax/Fbfeedpush.php(47): Facebook\BusinessExtension\Model\Product\Feed\Method\BatchApi->generateProductRequestData()
#5 /home/magento/magento2/app/code/Facebook/BusinessExtension/Controller/Adminhtml/Ajax/AbstractAjax.php(42): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\Fbfeedpush->executeForJson()
#6 /home/magento/magento2/vendor/magento/framework/Interception/Interceptor.php(58): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\AbstractAjax->execute()
#7 /home/magento/magento2/vendor/magento/framework/Interception/Interceptor.php(138): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\Fbfeedpush\Interceptor->___callParent()
#8 /home/magento/magento2/vendor/magento/framework/App/Action/Plugin/ActionFlagNoDispatchPlugin.php(51): Facebook\BusinessExtension\Controller\Adminhtml\Ajax\Fbfeedpush\Interceptor->Magento\Framework\Interception\{closure}()
```

Reviewed By: xiangminxufsu

Differential Revision: D26998474

fbshipit-source-id: e4fe52df244ee94d613ea719e97d304950f27d30
facebook-github-bot pushed a commit that referenced this issue Oct 21, 2022
Summary:
This is to avoid Magento exception in Stores -> Configuration when the Magento_InventoryApi module is disabled:

```
report.CRITICAL: Error: Cannot instantiate interface Magento\InventoryApi\Api\StockRepositoryInterface in /var/www/html/ego_240/vendor/mag
ento/framework/ObjectManager/Factory/AbstractFactory.php:121
Stack trace:
#0 /var/www/html/ego_240/vendor/magento/framework/ObjectManager/Factory/Compiled.php(108): Magento\Framework\ObjectManager\Factory\AbstractFactory->createObject()
#1 /var/www/html/ego_240/vendor/magento/framework/ObjectManager/ObjectManager.php(70): Magento\Framework\ObjectManager\Factory\Compiled->create()
#2 /var/www/html/ego_240/app/code/Facebook/BusinessExtension/Model/Config/Source/Product/InventoryStock.php(46): Magento\Framework\ObjectManager\ObjectManager->get()
#3 /var/www/html/ego_240/app/code/Facebook/BusinessExtension/Model/Config/Source/Product/InventoryStock.php(57): Facebook\BusinessExtension\Model\Config\Source\Product\InventoryStock->getStockRepository()
#4 /var/www/html/ego_240/vendor/magento/module-eav/Model/Entity/Attribute/Source/AbstractSource.php(168): Facebook\BusinessExtension\Model\Config\Source\Product\InventoryStock->getAllOptions()
#5 /var/www/html/ego_240/vendor/magento/module-config/Model/Config/Structure/Element/Field.php(461): Magento\Eav\Model\Entity\Attribute\Source\AbstractSource->toOptionArray()
```

Reviewed By: fbisaso

Differential Revision: D32070111

fbshipit-source-id: 103428392bc445e544d1b302a4e49296eba4628b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants