Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Split up ShipItUtil #5

Closed
fredemmott opened this issue Mar 21, 2016 · 1 comment
Closed

Split up ShipItUtil #5

fredemmott opened this issue Mar 21, 2016 · 1 comment
Assignees
@bigfootjon

Comments

@fredemmott
Copy link
Contributor

No description provided.

@fredemmott
Copy link
Contributor Author

Contains:

  • shell_exec() wrapper that could do with a refactor anyway (the flags are weird...)
  • matchesAnypattern(): random regexp helper
  • diff parsing functions

Diff parsing should move to ShipItRepo or a subclass, shellexec should be its' own thing.

@fredemmott fredemmott changed the title S Split up ShipItUtil Mar 21, 2016
ghost pushed a commit that referenced this issue Apr 18, 2016
@fredemmott
refactor shell command handling
f0c3dbd 
Summary:Needed to extend it to support environment variables. Fix some
annoyances with the existing API:

 - only able to get exit code if the exception is thrown (`git diff` often exits with 1 in non-error situations)
 - almost always specifying null stdin
 - almost always specifying DONT_VERBOSE
 - output was only printed at the end of a command (eg the slow git submodule command in HHVM looked like a hang)

Existing API is now a wrapper around the new one.

refs #12
refs #9
refs #5

Reviewed By: JoelMarcey

Differential Revision: D3186167

fb-gh-sync-id: d64a852facbc6e8ed167fe462ff51cd1e4bde621
fbshipit-source-id: d64a852facbc6e8ed167fe462ff51cd1e4bde621
facebook-github-bot pushed a commit that referenced this issue Aug 24, 2020
@bigfootjon @facebook-github-bot
Split most functions out of ShipItUtil
49179c2 
Summary:
This has been a longstanding GitHub issue and I'm in a fix-GitHub-issues kind of mood.

There are a lot callsites to `shellExec` that looked daunting, I'll take a look later.

refs #5

Reviewed By: yns88

Differential Revision: D23256237

fbshipit-source-id: 18f8ea9323a11e529a9830ef34d9d2fec2c3d57f
bigfootjon added a commit to bigfootjon/fbshipit that referenced this issue Aug 27, 2020
@bigfootjon @facebook-github-bot
Delete ShipItUtil and the deprecated exec function
2cb8504 
Summary:
Finally, we can remove this deprecated function and clean up all callsites. Honestly easier than I anticipated.

Closes facebookarchive#5

Differential Revision: D23378755

fbshipit-source-id: 77a79f0a984403c7ab33869125b9d4b2f017a0f4
@bigfootjon bigfootjon mentioned this issue Aug 27, 2020
Closed
bigfootjon added a commit to bigfootjon/fbshipit that referenced this issue Aug 27, 2020
@bigfootjon @facebook-github-bot
Delete ShipItUtil and the deprecated exec function (facebookarchive#115)
a52ee60 
Summary:
Pull Request resolved: facebookarchive#115

Finally, we can remove this deprecated function and clean up all callsites. Honestly easier than I anticipated.

Closes facebookarchive#5

Differential Revision: D23378755

fbshipit-source-id: 0cb5c1a65f5d397c38ab565c98a732a1de2e5019
@bigfootjon bigfootjon self-assigned this Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bigfootjon bigfootjon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete ShipItUtil and the deprecated exec function bigfootjon/fbshipit
2 participants
@fredemmott @bigfootjon