Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Stop user git/hg config from breaking things #9

Closed
fredemmott opened this issue Apr 11, 2016 · 0 comments
Closed

Stop user git/hg config from breaking things #9

fredemmott opened this issue Apr 11, 2016 · 0 comments

Comments

@fredemmott
Copy link
Contributor

fredemmott commented Apr 11, 2016 •
edited
Loading

It looks like the right things to do are:

  • set HGPLAIN=1 for hg
  • set GIT_CONFIG_NOSYSTEM=1 for git
@fredemmott fredemmott changed the title Use HGPLAIN so that user config can't break hg export Stop user git/hg config from breaking things Apr 15, 2016
ghost pushed a commit that referenced this issue Apr 18, 2016
@fredemmott
refactor shell command handling
f0c3dbd 
Summary:Needed to extend it to support environment variables. Fix some
annoyances with the existing API:

 - only able to get exit code if the exception is thrown (`git diff` often exits with 1 in non-error situations)
 - almost always specifying null stdin
 - almost always specifying DONT_VERBOSE
 - output was only printed at the end of a command (eg the slow git submodule command in HHVM looked like a hang)

Existing API is now a wrapper around the new one.

refs #12
refs #9
refs #5

Reviewed By: JoelMarcey

Differential Revision: D3186167

fb-gh-sync-id: d64a852facbc6e8ed167fe462ff51cd1e4bde621
fbshipit-source-id: d64a852facbc6e8ed167fe462ff51cd1e4bde621
@ghost ghost closed this as completed in 1b881ed Apr 18, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fredemmott