Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Commit

Permalink
Fix glog command line arguments on a clean build
Browse files Browse the repository at this point in the history
Summary:
To support glog's command line arguments like --logtostderr, it requires gflags.

If gflags is not found, glog will still compile but the command line arguments will be absent.

As glog was created before gflags, that was the case on a clean build.
Note that on subsequent builds gflags already existed, so a second build 'magically' made the command line arguments appear.

Title: glog flags like --logtostderr are missing on a clean build

Description:

See facebook/openr#28
Closes #10

Differential Revision: D8168516

Pulled By: saifhhasan

fbshipit-source-id: b8185bcc8ba7411254b66e8ed0a9edc9d689efaf
  • Loading branch information
jeroend authored and facebook-github-bot committed May 25, 2018
1 parent 32a6e8f commit c962a3c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/build_fbzmq.sh
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ apt-get install libdouble-conversion-dev \
python3-setuptools \
python-pip

install_glog
install_gflags
install_glog # Requires gflags to be build first
install_gtest
install_mstch
install_zstd
Expand Down

0 comments on commit c962a3c

Please sign in to comment.