Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Fix glog command line arguments on a clean build #10

Closed

Conversation

jeroen-dhollander
Copy link

To support glog's command line arguments like --logtostderr, it requires gflags.

If gflags is not found, glog will still compile but the command line arguments will be absent.

As glog was created before gflags, that was the case on a clean build.
Note that on subsequent builds gflags already existed, so a second build 'magically' made the command line arguments appear.

Pull Request Template

Title: glog flags like --logtostderr are missing on a clean build

Description:

See facebook/openr#28

Test Plan:

  • On my OpenR code I compiled it before and after the reorder, and noticed the different behavior.
  • No additional testing was performed for this fbzmq fix.

Pull Request Guideline

  • Before sending a pull request make sure each commit solves one clear, minimal,
    plausible problem. Further each commit should have the above format.
  • Please avoid sending a pull request with recursive merge nodes, as they
    are impossible to fix once merged. Please rebase your branch on
    facebook/openr master instead of merging it.
  • If you are a new contributor please have a look at our contributing guidelines:
    CONTRIBUTING

To support glog's command line arguments like --logtostderr, it requires gflags.

If gflags is not found, glog will still compile but the command line arguments will be absent.

As glog was created before gflags, that was the case on a clean build.
Note that on subsequent builds gflags already existed, so a second build 'magically' made the command line arguments appear.
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saifhhasan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants