This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Add help tips to label icons [#85] #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliemt
force-pushed
the
feature/field-label-tooltip
branch
4 times, most recently
from
c849eb4
to
38704f4
Compare
gisedaye
suggested changes
Feb 25, 2021
There was a problem hiding this comment.
@nataliemt it looks great just a small comment about how I think we should handle the react components.
nataliemt
force-pushed
the
feature/field-label-tooltip
branch
from
38704f4
to
6b3d87e
Compare
nataliemt
force-pushed
the
feature/field-label-tooltip
branch
from
6b3d87e
to
182b85f
Compare
gisedaye
approved these changes
Feb 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#85
According with the discussion from the GitHub issue, add messaging to explain when a field is required, optional, or just controlling the appearance of other fields. The message can be displayed onmouseover (:hover) the icons.
After:
