Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Handle issue with preview #141 #146 #157

Merged
merged 2 commits into from Feb 26, 2021
Merged

Handle issue with preview #141 #146 #157

merged 2 commits into from Feb 26, 2021

Conversation

nataliemt
Copy link
Contributor

@nataliemt nataliemt commented Feb 24, 2021 •
edited

#141 #146

Handled issues with preview.

  • Updated semantic-ui-react version
  • Added validation when calling preview service by preventing to pass the rules in case it does not contain the required fields to avoid the attempt of loading the preview without fields.

Result:
Screen Shot 2021-02-24 at 18 16 30 (2)
Screen Shot 2021-02-24 at 18 18 25 (2)

@nataliemt nataliemt self-assigned this Feb 24, 2021
gisedaye
gisedaye approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@gisedaye gisedaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great Natalie, thanks for working on this!
Added just a minor comment for an improvement, but fell free to do it on a different PR if needed

src/js/components/Preview.react.js Show resolved Hide resolved
@nataliemt nataliemt merged commit f5ff5bf into master Feb 26, 2021
@nataliemt nataliemt deleted the feature/preview-issues branch February 26, 2021 19:52
@lokersumatera
Copy link

can you try it on windows 10? after updating some of the files concerned. still can't preview

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gisedaye gisedaye gisedaye approved these changes

@pestevez pestevez Awaiting requested review from pestevez

Assignees

@nataliemt nataliemt

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nataliemt @lokersumatera @gisedaye @facebook-github-bot