This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
More updates for CLI / new API #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using inlineSourceMap, result.code will now have the sourceMap encoded and appended. This matches more closely what we did in react-tools. We won't also return the raw sourcemap data (this matches what Babel does). - Expose a new option sourceMap which will result in the sourceMap being in the result. - Pre-JSONify the SourceMapGenerator instead of returning it directly. - Make sure 'source.js' actually is the default for sourcemaps. - Make sure the API works when no options are passed. - Don't expose result directly from jstransform, only expose specific values.
Mostly this is to make sure source maps get a good filename, which will mostly be correct-ish. It also makes the other defaults explicit.
Document the Advanced API as well as all the new stuff.
|
whatttttttttt? I left this disclaimer for a reason #81 (comment) 😛
|
|
Found (another) bug #102 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I missed a bunch of things in the CLI & new API. Bugs (I blame @zertosh for not catching them 😉), bad options. This makes things better. And then I wrote a readme.
cc @spicyj @amasad @jeffmo