Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

User ignores stopped working #178

Open
domenkozar opened this issue Oct 13, 2016 · 10 comments
Open

User ignores stopped working #178

domenkozar opened this issue Oct 13, 2016 · 10 comments

Comments

@domenkozar
Copy link

domenkozar commented Oct 13, 2016

Given the following configuration: https://github.com/NixOS/nixpkgs/blob/master/.mention-bot

User still got mentioned on a new PR NixOS/nixpkgs#19492 (comment)

@FRidh
Copy link

FRidh commented Oct 13, 2016

Actually, I think the whole file is being ignored. I'm in "alwaysNotifyForPaths" for pkgs/top-level/python-packages.nix and there have been several PR's this week where I wasn't notified but others were.

Examples: NixOS/nixpkgs#19461 NixOS/nixpkgs#19450 NixOS/nixpkgs#19296

@erlend-sh
Copy link

Yep, seeing the same thing here:

discourse/wp-discourse#254

@domenkozar
Copy link
Author

@vjeux

@vjeux
Copy link
Contributor

vjeux commented Oct 17, 2016

Hey, I'm sorry but I don't have the time to look into it. Would be nice if you could run your own instance and put console.log in places and troubleshot what's going on. Sorry about this!

@domenkozar
Copy link
Author

@vjeux this could be duplicate of #173

@jeffreyleeon
Copy link
Contributor

jeffreyleeon commented Nov 24, 2016

Tackled in #186.

And issue description in #185

@domenkozar
Copy link
Author

@jeffreyleeon
Copy link
Contributor

@domenkozar I have just tried your configurations and it works fine even without the patch.
Sorry for bothering you, I will try if I can find out what's breaking your repo. :)

@rochacbruno
Copy link

Same happen here https://github.com/SatelliteQE/robottelo/blob/master/.mention-bot

Even with that names in ignore list, bot keeps mentioning as you can see here: SatelliteQE/robottelo#4217

@luckydonald
Copy link

Also happening to me at nextcloud/server#3382 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants