Changing Credited Name to Real Name on the Settings Page #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you sign up, you're asked to enter your Real Name, but in the Settings page that is referred to as Credited name. This change alters the Settings page reference to Real name. This only affects the UX and nothing deeper.
|
Adding alumni to the mention-bot blacklist didn't seem to work then da3457c |
|
@simoneduca Looks like mention bot is ignoring the config for others too: facebookarchive/mention-bot#178 |
|
LGTM @BNewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when you sign up, you're asked for your 'Real Name', but on the settings page this is referred to as 'Credited Name'. This suggested change would alter the reference on the Settings page to 'Real Name' so that they match up.
It doesn't change anything deeper than what is displayed in the web page though, and it looks like in the code in other places it might still be being referred to as credited name. At the moment, I've no idea how to change any of that.
This suggestion is a result of the glossary that Meg and I are writing - it was in defining the term in the glossary that we noticed that they're called different things in the two places.