Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guile: add libiconv as buildInput on darwin #19492

Closed
wants to merge 1 commit into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 12, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • OS X
    • Np changes on other platforms
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Oct 12, 2016
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @civodul, @edolstra and @lovek323 to be potential reviewers.

@copumpkin
Copy link
Member

copumpkin commented Oct 12, 2016

Can you elaborate on why guile works for me without this on Darwin?

Compare to #19470 (comment)

@LnL7
Copy link
Member Author

LnL7 commented Oct 12, 2016

I was just going to ask you, I've seen a bunch of failures on hydra with the same issue.

@edolstra edolstra closed this in ed60067 Oct 12, 2016
@copumpkin
Copy link
Member

Thank you both for tackling this so quickly!

@LnL7 LnL7 deleted the darwin-guile branch October 12, 2016 18:34
@civodul
Copy link
Contributor

civodul commented Oct 12, 2016

Mention Bot notifications@github.com skribis:

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @civodul, @edolstra and @lovek323 to be potential reviewers.

It seems Mention Bot has ignored to ignore me again. Could you look
into it?

TIA! :-)

Ludo’.

@domenkozar
Copy link
Member

@civodul I've opened facebookarchive/mention-bot#178 to address this. Sorry for inconvenience :)

edolstra added a commit that referenced this pull request Oct 13, 2016
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants