This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 682
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Relax ordering restriction for eval ids
Summary: Here is a correct scenario in which evaluation requests can be completed "out of order": 1. eval request #1 is sent, push #1 onto stack 2. eval request #2 is sent, push #2 onto stack 3. response for #1 comes back from HHVM, pop #2 off stack 4. #1 != #2 so the invariant is triggered So we can be more lax about the expected order that we receive responses. In general, there's no reason to impose any restrictions on the ordering in which requests and responses happen, so let's just use a set. Changelog: Fix for PHP debugger evaluation crashes. Reviewed By: yinghuitan Differential Revision: D4282772 fbshipit-source-id: 7d6169fa660d489b06b1a28e07140fa11a5464e4
- Loading branch information
1 parent
fdd9c09
commit e0725e7
Showing
2 changed files
with
13 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters