Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Atom's built-in tree view still active. #4

Closed
lutherism opened this issue May 27, 2015 · 2 comments
Closed

Atom's built-in tree view still active. #4

lutherism opened this issue May 27, 2015 · 2 comments

Comments

@lutherism
Copy link
Contributor

After first installing, I had two file tree view panels on the left side. The built-in Atom tree view was present. I fixed by going into Packager Manger > tree-view > Disable. Would it be possible for the installer to disable it?
@simonwelsh
Copy link

Duplicate of #3.

jgebhardt pushed a commit that referenced this issue Aug 31, 2015
@rameshvarun
Service Framework 3.0 Diff #4 - Remote Interface Parsing
34838fa
@randunel
Copy link

@simonwelsh this is not a duplicate of #3. This issue persists with current releases of atom (1.4.0) and nuclide (0.111.0).

ghost pushed a commit that referenced this issue Jun 24, 2016
@johnislarry
Console diff #4 -- Add "Cached Mode" to LazyNestedValueComponent
b7a261e 
Summary:
The semantics for console evaluation are different from the watch window, because we don't want to refetch values from the backend once we already have them.  An example of where this is useful is the following scenario:

1. Attach debugger and evaluate things in the console.
2. Detach the debugger and try to expand and collapse the things you evaluated.

Since the backend has gone away, if we don't do any caching, then we get a loading spinner that will never return.

This caching is also useful because people don't expect their (already expanded) expressions to re-evaluate if some later side-effect occurs.

The approach I took here is to:
1. Only cache ExpansionResults gotten from the backend, and
2. Store these cached ERs in the TopLevelComponent, so that this data can persist across re-renders.

Reviewed By: jgebhardt

Differential Revision: D3472324

fbshipit-source-id: 95b52833d7aa3ab25cdd8e16d2e2e32c891c3914
ghost pushed a commit that referenced this issue Sep 23, 2016
@johnislarry
request sender #4 -- Add new debugger API for adding custom buttons i…
5aa6120 
…n the stepping component

Summary: Different debuggers may want to put buttons here so let's give them an API for doing that.

Reviewed By: jgebhardt

Differential Revision: D3809132

fbshipit-source-id: 8501fbe4d5dfb3151cde209a5693a7f958736fd2
facebook-github-bot pushed a commit that referenced this issue Oct 7, 2016
@johnislarry
iwdp debugger #4 -- implement file cache for managing files served fr…
43318c6 
…om iwdp

Summary: This provides an abstraction for translating between URLs and files on disk.  URLs are provided by the IWDP server, and map to js bundles or source maps.

Reviewed By: jgebhardt

Differential Revision: D3989142

fbshipit-source-id: 6c64090a32f4866c5e2e66eca450793a7d3bb7e6
facebook-github-bot pushed a commit that referenced this issue Feb 4, 2017
@johnislarry @facebook-github-bot
disposal #4: Refactor Socket class out of DebuggerConnection
71e849d 
Summary:
DebuggerConnection was getting pretty gnarly, so this pulls out the nitty gritty websocket munging
logic into its own abstraction.

Differential Revision: D4505739

fbshipit-source-id: 2f413efd6b1ab68dec1c1a8ca0f26ee8290d16eb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonwelsh @randunel @lutherism