This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Fix exception on jsimports startup (#1448) #1480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansonw has updated the pull request. |
|
|
Updated atom to 1.25.0-beta3 got the same error in devtools there is some errors to |
|
Ah that's probably due to the transpiler. Try commenting out that block of
code to see what happens.
On Mar 14, 2018 5:33 AM, "Vytenis" <notifications@github.com> wrote:
Updated atom to 1.25.0-beta3 got the same error
Couldn't initialize jsimports server - Request initialize failed with
message: globalsJSON is not defined
in devtools there is some errors to
-1521030784468.log
<https://github.com/facebook/nuclide/files/1811019/-1521030784468.log>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1480 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjPYicaAp6poTNqrFgWQ_L6ZoWVmER9ks5teQ4xgaJpZM4Sp2sb>
.
|
|
No errors 👯 |
|
Awesome. thanks for verifying! |
There was a problem hiding this comment.
@hansonw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FDiskas I think this is the issue in #1448. Could you try manually patching this into
~/.atom/packages/nuclide/pkg/nuclide-js-imports-server/src/lib/UndefinedSymbolManager.jsto see if that does the trick?