-
Notifications
You must be signed in to change notification settings - Fork 682
add disable atom's default tree-view on file-tree package load #25
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@@ -17,6 +17,14 @@ var subscriptions: ?CompositeDisposable = null; | |||
|
|||
module.exports = { | |||
activate(state: ?FileTreeControllerState): void { | |||
|
|||
// disable atom's default tree view | |||
if (atom.config.get('core.disabledPackages').length === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep a reference to the config object to simplify this?
var coreDisabledPackages = atom.config.get('core.disabledPackages');
if (coreDisabledPackages.length === 0 ||
coreDisabledPackages.indexOf('tree-view') === -1) {
atom.config.pushAtKeyPath('core.disabledPackages', 'tree-view');
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@ssorallen anything else you would like me to change? |
@knowbody, we are looking at some additions to your pull request internally. Specifically, when you disable the nuclide-file-tree package the bundled Atom file-tree should re-enable. |
👍 cool, @ssorallen let me know if I can help somehow |
@ssorallen this can be closed as you fixed it internally now with:
|
Great. Thanks for pull request, it prompted us to make nuclide-file-tree interact with Atom's tree-view better. If you still have problems, please comment or re-open the PR/issue. |
This is in reference to #3