Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Tease apart expressions vs. statements for operation descriptors #2479

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions src/serializer/ResidualHeapSerializer.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import type {
import { Generator } from "../utils/generator.js";
import { PreludeGenerator } from "../utils/PreludeGenerator.js";
import { NameGenerator } from "../utils/NameGenerator.js";
import type { OperationDescriptor, SerializationContext } from "../utils/generator.js";
import type { SerializationContext } from "../utils/generator.js";
import invariant from "../invariant.js";
import type {
ResidualFunctionBinding,
Expand Down Expand Up @@ -1998,7 +1998,7 @@ export class ResidualHeapSerializer {
return t.memberExpression(obj, prop, true);
}
invariant(val.operationDescriptor !== undefined);
let serializedValue = this.residualOperationSerializer.serialize(val.operationDescriptor, serializedArgs);
let serializedValue = this.residualOperationSerializer.serializeExpression(val.operationDescriptor, serializedArgs);
if (serializedValue.type === "Identifier") {
let id = ((serializedValue: any): BabelNodeIdentifier);
invariant(
Expand Down Expand Up @@ -2212,21 +2212,9 @@ export class ResidualHeapSerializer {
// along the code of the nested generator; their definitions need to get hoisted
// or repeated so that they are accessible and defined from all using scopes
let context = {
serializeOperationDescriptor: (
operationDescriptor: OperationDescriptor,
nodes: Array<BabelNodeExpression>,
_context: SerializationContext,
valuesToProcess: Set<AbstractValue | ObjectValue>
) => {
let serializedValue = this.residualOperationSerializer.serialize(
operationDescriptor,
nodes,
_context,
valuesToProcess
);

return ((serializedValue: any): BabelNodeStatement);
},
serializeOperationDescriptor: this.residualOperationSerializer.serializeStatement.bind(
this.residualOperationSerializer
),
serializeBinding: this.serializeBinding.bind(this),
serializeBindingAssignment: (binding: Binding, bindingValue: Value) => {
let serializeBinding = this.serializeBinding(binding);
Expand Down
Loading