This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Hotfix openURLFromButton: crash #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using openURLFromButton: we will likely be calling this from a UIBarButtonItem object, which isn't a descendant of the UIView class. We return the global navigator because there's no simple way to determine the class from the bar button item. This is a trade-off of ease-of-use over proper functionality here. If you want to get a UIBarButtonItem to open a specific navigator, handle the button tapped method yourself and get the correct navigator.
|
Added note to the header documenting this special case. |
|
Merge branch 'hotfix-openURLFromButton-crash' Closed by 2ce7b12. |
diederich
pushed a commit
that referenced
this pull request
Apr 17, 2011
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using openURLFromButton: we will likely be calling this from a
UIBarButtonItem object, which isn't a descendant of the UIView class.
We return the global navigator because there's no simple way
to determine the class from the bar button item. This is a
trade-off of ease-of-use over proper functionality here. If you want
to get a UIBarButtonItem to open a specific navigator, handle the
button tapped method yourself and get the correct navigator.