Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Removing ZipTable from library #6

Merged
merged 1 commit into from
May 27, 2017
Merged

Conversation

oserban
Copy link

@oserban oserban commented May 25, 2017

No description provided.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jgehring
Copy link
Contributor

Thanks for the fix, @oserban. However, nn.ZipTable was added very recently to nn and is thus not available in a standard install via torch/distro, for example. As a temporary workaround, can you please leave ZipTable.lua in place and wrap the require like this:

if not nn.ZipTable then
    -- ZipTable is missing from older nn versions
    require 'rnnlib.nn.ZipTable'
end

Once the nn version in torch/distro is up to date we can happily drop the duplicated code.

@oserban
Copy link
Author

oserban commented May 26, 2017

Cheers @jgehring for the suggestion. Better keep everything backward compatible ...

@jgehring
Copy link
Contributor

Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants