Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): i18n site: enable ko + zh-CN locales #4599

Merged
merged 2 commits into from
Apr 11, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 11, 2021

Motivation

ko and zh-CN have enough translations on Crowdin (according to threshold we defined in #3526)

Let's enable those locales in production!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 11, 2021
@slorber slorber requested a review from lex111 as a code owner April 11, 2021 16:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 11, 2021
@netlify
Copy link

netlify bot commented Apr 11, 2021

[V1]

Built with commit 364fa8c

https://deploy-preview-4599--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 11, 2021

Size Change: +1.98 kB (0%)

Total Size: 578 kB

Filename Size Change
website/build/assets/js/main.********.js 401 kB +155 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB +1.03 kB (+2%)
website/build/index.html 26.9 kB +798 B (+3%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Apr 11, 2021

[V2]

Built with commit 364fa8c

https://deploy-preview-4599--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4599--docusaurus-2.netlify.app/

@slorber slorber merged commit 41af0c9 into master Apr 11, 2021
@slorber slorber deleted the slorber/enable-ko-zh-CN branch August 17, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants