Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume for IT lang #4

Closed
wants to merge 1 commit into from
Closed

Conversation

matteoredaelli
Copy link

I notice that there are several missing dimensions for the IT language: this patch is for the Volume dimension

Regards
Matteo

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@matteoredaelli
Copy link
Author

Done

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@patapizza has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@patapizza
Copy link
Contributor

Thanks @matteoredaelli!

For the record, I made a few changes:

  • added tests/Duckling/Volume/IT/Tests.hs
  • updated tests/Duckling/Volume/Tests.hs
  • fixed litros -> litr(i|o)
  • fixed galo, galon(e|i) -> gal, gallon(e|i)

Make sure to include the new tests and run them next time ;-)

arjan pushed a commit to botsquad/duckling that referenced this pull request Jun 26, 2020
serapio pushed a commit to cisco/duckling that referenced this pull request Oct 14, 2022
* Update Dockerfile for our systems

* Update README with Docker instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants