Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated HIP flags #360

Closed
wants to merge 3 commits into from
Closed

Remove deprecated HIP flags #360

wants to merge 3 commits into from

Commits on May 11, 2023

  1. Remove deprecated HIP flags 

    Removes the outdated HIP flags appended to HIP_CXX_FLAGS

The will help remove the following warnings in the pytorch build log

```
[6238/6889] Building CXX object caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/cudnn/hip/Conv_v8.cpp.o
cc1plus: warning: command line option ‘-Wno-duplicate-decl-specifier’ is valid for C/ObjC but not for C++
cc1plus: warning: unrecognized command line option ‘-Wno-unused-command-line-argument’
cc1plus: warning: unrecognized command line option ‘-Wno-exceptions’
cc1plus: warning: unrecognized command line option ‘-Wno-inconsistent-missing-override’
cc1plus: warning: unrecognized command line option ‘-Wno-macro-redefined’
```

There is a similar change also required in `pytorch/cmake/Dependencies.cmake` to fully remove these warnings
    @jataylo
    jataylo authored May 11, 2023
    Configuration menu
    Copy the full SHA
    9d5418f View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Replace deprecated amdgpu-target with offload-arch

    @jataylo
    jataylo authored May 15, 2023
    Configuration menu
    Copy the full SHA
    a7a8193 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merge branch 'main' into patch-1

    @jataylo
    jataylo authored May 18, 2023
    Configuration menu
    Copy the full SHA
    2467473 View commit details
    Browse the repository at this point in the history