Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Qualify all ambiguous references to folly::Optional
Summary: Having the lines `using namespace testing;` and `using namespace folly;` or `using folly::Optional;` causes a build error with the new googletest version because of `testing::Optional` being a new symbol from googletest ## How I made this diff: From the list of files [rquitt@devbig013.ftw5 ~/fbsource/fbcode/scripts/rquitt] grep -r "'Optional' is ambiguous" | sed 's/stderr: //' | cut -d ':' -f 2 | sort -u admarket/adreview/video_understanding/server/test/VusMothershipManagerTest.cpp admarket/adreview/video_understanding/server/test/VusTaskManagerTest.cpp archive_service/blockio/SdcLogicalBlockWriterTest.cpp ... Open all the files in Vim and use a command like: `:%s/[^y/:]Optional/folly::Optional/` Also removed all the `using folly::Optional;` lines to discourage further use of ambiguous `Optional` before googletest change is landed. The alternative to this diff would be to not export `testing::Optional` from googletest. Reviewed By: igorsugak Differential Revision: D26358560 fbshipit-source-id: ae8695b3525bf333758b012adcfe944383777625
- Loading branch information