Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using pipeline_builder shared pointer multiple times lead to segfaults #369

Open
artemru opened this issue Mar 5, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@artemru
Copy link
Contributor

artemru commented Mar 5, 2024

Describe the bug:
Segfault during the pipeline creation

Describe how to reproduce:

from fairseq2.data import read_sequence
from fairseq2.data.data_pipeline import DataPipeline, DataPipelineBuilder

pipeline_build = read_sequence(list(range(100)))  # this's shared for two shuffling operations

concat_pipe = DataPipeline.concat([pipeline_build.shuffle(10).and_return(),
                                   pipeline_build.shuffle(10).and_return()]).and_return()
# this should have raised 
next(iter(concat_pipe))

Describe the expected behavior:
This should raise an explicit RuntimeError

@artemru artemru added the bug Something isn't working label Mar 5, 2024
@cbalioglu
Copy link
Contributor

Thanks for the report! I will investigate it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants