Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in test_sample.py failing on main branch #75

Closed
vb000 opened this issue Sep 30, 2023 · 2 comments
Closed

Tests in test_sample.py failing on main branch #75

vb000 opened this issue Sep 30, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@vb000
Copy link

vb000 commented Sep 30, 2023

I installed fairseq2 in edit mode following the instructions here. I did a quick pytest to test the installation to see following these errors:

=================================================================================================================== short test summary info ===================================================================================================================
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_works_as_expected - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_works_as_expected_with_different_lenghts - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_works_as_expected_with_default_weights - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_works_as_expected_with_low_prob - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_works_as_expected_with_single_data_pipeline - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_works_as_expected_with_empty_data_pipelines - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_works_as_expected_with_manual_seed - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_raises_invalid_argument_if_negative_weights - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_raises_invalid_argument_if_weights_wrong_size - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_raises_invalid_argument_if_weights_sum_to_zero - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_raises_error_if_no_data_pipeline - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_op_raises_error_if_one_of_the_pipelines_is_broken - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
FAILED tests/unit/data/data_pipeline/test_sample.py::TestSampleOp::test_record_reload_position_works_as_expected - AttributeError: type object 'fairseq2n.bindings.data.data_pipeline.DataPipeline' has no attribute 'sample'
========================================================================================================== 13 failed, 377 passed, 1 skipped in 1.46s ==================================================================================================

I took a look at the latest PR (#20), and the CI seems to be skip them:
Screenshot 2023-09-30 at 2 24 07 PM

Are these failures expected? And, is there a way a ignore them locally?

@vb000 vb000 added the question Further information is requested label Sep 30, 2023
@cbalioglu
Copy link
Contributor

@vb000 thanks for reporting it. It is actually something we should fix in our CI and test framework, working on it right now. I will have a PR later today.

@cbalioglu cbalioglu added bug Something isn't working and removed question Further information is requested labels Oct 2, 2023
@cbalioglu cbalioglu self-assigned this Oct 2, 2023
@cbalioglu
Copy link
Contributor

Fixed in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants