Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollisionGroup::Noncollidable fix #1449

Conversation

eundersander
Copy link
Contributor

Motivation and Context

Fix to ensure CollisionGroup::Noncollidable has a mask of 0 and thus collides with nothing.

The previous code used a mask of -1, with the result that a Noncollidable would collide with another Noncollidable.

How Has This Been Tested

Ad hoc local testing

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 23, 2021
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
We should add a test, then ship it.
Adding the following at the end of test_collision_groups() should do.

# test Noncollidable
cube_obj1.override_collision_group(cg.Noncollidable)
assert not cube_obj1.contact_test()
assert not cube_obj2.contact_test()

@eundersander eundersander merged commit 1e6239e into facebookresearch:master Aug 24, 2021
@eundersander eundersander deleted the eundersander/noncollidable_fix branch August 24, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants