Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix][colab] Dynamically pin numba to appropiate colab version #1459

Merged
merged 1 commit into from
Aug 30, 2021
Merged

[bugfix][colab] Dynamically pin numba to appropiate colab version #1459

merged 1 commit into from
Aug 30, 2021

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • This pin's numba to the appropriate colab version.
  • It also allows more flexible matching of colab requirements (minor version can differ).

How Has This Been Tested

  • Colab

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

aclegg3
aclegg3 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Skylion007 Skylion007 merged commit af3a4d7 into master Aug 30, 2021
@Skylion007 Skylion007 deleted the colab-conda-numba-patch branch August 30, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Skylion007 @aclegg3