Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache and query for ArticulatedObject global scaling. #1466

Merged
merged 5 commits into from
Sep 3, 2021

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Sep 2, 2021

Motivation and Context

Articulated objects can be programmatically scaled upon instantiation in the scene. Any geometric metadata defined in the original frame should be scaled also, requiring that this global scale is cached when the object is created and queryable later.

How Has This Been Tested

Added a simple test in python.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 2, 2021
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How did I miss this? :)

requirements.txt Outdated
@@ -6,6 +6,6 @@ matplotlib
numba
numpy
numpy-quaternion
pillow
pillow<=8.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing requirements because of wheel dependencies is a silly and if you HAVE to do it, then use the magic python version comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pip magic.

@aclegg3 aclegg3 dismissed Skylion007’s stale review September 3, 2021 00:22

Changes addressed.

@aclegg3 aclegg3 merged commit 983cfa1 into master Sep 3, 2021
@aclegg3 aclegg3 deleted the ao-global-scale branch September 3, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants