[TechDebt] Refactor tests to all be in tests directory, and to use Corrade test suite (Part 2 of 2) #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
Refactor_Tests_MoveToTestDir
branch
from
6da7744
to
be763de
Compare
aclegg3
approved these changes
Sep 14, 2021
| CORRADE_COMPARE(scene->objects().size(), 94); | ||
|
|
||
| CORRADE_VERIFY(scene->objects()[12] != nullptr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This 2nd of 2 PRs moves the tests that were in various directories to all be within the tests directory, and refactored the GibsonScene/GibsonSemanticScene tests to use Corrade tests suite. As of this PR, no Habitat-sim tests are using gtest anymore, and that dependency can now be removed.
How Has This Been Tested
Locally all c++ tests pass
Types of changes
Checklist