[TechDebt]--Cleanup superfluous IO functions #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mosra
reviewed
Sep 15, 2021
src/esp/assets/PTexMeshData.cpp
Outdated
| @@ -760,7 +759,7 @@ void PTexMeshData::parsePLY(const std::string& filename, | |||
| Cr::Containers::Array<const char, Cr::Utility::Directory::MapDeleter> | |||
| mmappedData = Cr::Utility::Directory::mapRead(filename); | |||
|
|
|||
| const size_t fileSize = io::fileSize(filename); | |||
| const auto fileSize = *Cr::Utility::Directory::fileSize(filename); | |||
There was a problem hiding this comment.
Could have stayed as size_t, I think?
(Argh, why I don't have it 64-bit always? 😱)
Skylion007
approved these changes
Sep 15, 2021
jturner65
force-pushed
the
Refactor_Cleanup
branch
from
024c155
to
ebf2932
Compare
jturner65
force-pushed
the
Refactor_Cleanup
branch
from
ed34ca7
to
0a4d60a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This small PR removes some file-based functions from Habitat that replicate functionality provided by Corrade. It further edits existing ones to use Corrade utilities instead of re-inventing the wheel.
How Has This Been Tested
Local C++ and python tests pass
Types of changes
Checklist