Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Stops nightly-condabuild from corrupting itself. #1479

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Miniconda is installed, unnecessary dependencies are installed and Anaconda are installed through the installer script all corrupting each other.

How Has This Been Tested

  • Should just work.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 15, 2021
@Skylion007
Copy link
Contributor Author

As an aside, this logic should be merged in with a parameterized version of test-conda build so that test-conda-build actually contributes to testing the nightly build. The conda nightly build should also be parallelized across circleci.

@Skylion007 Skylion007 changed the title [CI] Stops nightly-condabuild from corrupting itself;. [CI] Stops nightly-condabuild from corrupting itself. Sep 15, 2021
@Skylion007 Skylion007 merged commit b7b00cb into master Sep 17, 2021
@Skylion007 Skylion007 deleted the fix-conda-nightly branch September 17, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants