Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix]--Fix improper JSON object access. #1493

Merged
merged 1 commit into from
Sep 21, 2021
Merged

[BugFix]--Fix improper JSON object access. #1493

merged 1 commit into from
Sep 21, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This fixes an improper access to a JSON object - Objects do not have Size function. Just removed query.

How Has This Been Tested

Locally c++ build (using debug flag that exposed issue originally)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 20, 2021
@jturner65 jturner65 changed the title [BUGFIX]--fix improper JSON object access. [BugFix]--fix improper JSON object access. Sep 21, 2021
@jturner65 jturner65 changed the title [BugFix]--fix improper JSON object access. [BugFix]--Fix improper JSON object access. Sep 21, 2021
@jturner65 jturner65 merged commit 8c4553e into facebookresearch:main Sep 21, 2021
@jturner65 jturner65 deleted the BugFix_LightAttributes branch September 21, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jturner65 @Skylion007 @facebook-github-bot