Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TechDebt]--Minor refactors #1495

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Sep 21, 2021

Motivation and Context

This PR has a few minor refactors that improve functionality :

  • Changing aborts to python errors in bindings that hide Configuration::set for Attributes.
  • Improved Log message formatting.

How Has This Been Tested

Local C++ and python

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 21, 2021
@jturner65 jturner65 merged commit d7aaa96 into facebookresearch:main Sep 21, 2021
@jturner65 jturner65 deleted the MinorRefactors branch September 21, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants