[Bugfix]--address segfaults by catching nullptr attribs and exiting gracefully #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
approved these changes
Oct 4, 2021
eundersander
reviewed
Oct 4, 2021
src/esp/sim/Simulator.cpp
Outdated
| @@ -217,6 +217,14 @@ Simulator::setSceneInstanceAttributes(const std::string& activeSceneName) { | |||
|
|
|||
| metadata::attributes::SceneAttributes::cptr curSceneInstanceAttributes = | |||
| metadataMediator_->getSceneAttributesByName(activeSceneName); | |||
| // check if attributes is null - should not happen | |||
| CORRADE_ASSERT( | |||
There was a problem hiding this comment.
Is it possible to hit any of these by calling from python into Habitat-sim in a certain way, or by calling into Habitat-sim with certain files on the filesystem missing?
If yes, this feels more like an ESP_CHECK.
There was a problem hiding this comment.
yes, great point, thanks @eundersander
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
Bugfix_nullptrSegFault
branch
from
3bd8cc8
to
3bdc221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR addresses segfaults that would happen if, due to misspelling or other errors, a required or expected attributes necessary for scene building is not found (i.e. queries to MetadataMediator returned nullptr). Now, should these queries fail, a salient message is displayed and the program ends via std::abort.
How Has This Been Tested
C++ and python tests pass locally
Types of changes
Checklist