Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI]: Add hooks to ban blanket lint ignores #1527

Merged
merged 1 commit into from
Oct 7, 2021
Merged

[CI]: Add hooks to ban blanket lint ignores #1527

merged 1 commit into from
Oct 7, 2021

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Cleans up the linting type / noqa ignores to ensure that any new errors aren't accidentally masked by previous type ignores.
  • Adds a pre-commit hook which forbids blanket noqas and type:ignores. All linter ignore must now be specific.

How Has This Been Tested

  • Locally with CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

eundersander
eundersander approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skylion007
Copy link
Contributor Author

We should add this on Hab-Lab as well at some point. 👍

@Skylion007 Skylion007 merged commit ab0c4c6 into main Oct 7, 2021
JuanTheEngineer pushed a commit that referenced this pull request Oct 8, 2021
@Skylion007 @JuanTheEngineer
Add hooks to ban blanket lint ignores (#1527)
b052b7b
@jturner65 jturner65 deleted the precommit_ban_blankets branch November 29, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eundersander eundersander eundersander approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@erikwijmans erikwijmans Awaiting requested review from erikwijmans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Skylion007 @eundersander