Some conda fixes #1534
Merged
Some conda fixes #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
approved these changes
Oct 12, 2021
Skylion007
reviewed
Oct 12, 2021
.circleci/config.yml
Outdated
| @@ -678,7 +678,10 @@ workflows: | |||
| - install_and_test_ubuntu | |||
| - pre-commit | |||
| - build_conda_binaries: | |||
| CI_TEST: true | |||
| # CI_TEST: true | |||
| AIHABITAT_CONDA_CHN: aihabitat-nightly | |||
There was a problem hiding this comment.
Did this workflow run? I don't see the new files on https://anaconda.org/aihabitat-nightly/habitat-sim/files
|
@erikwijmans LGTM, let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove the old
test_conda_buildworkflow. Fix the non-CI test version of the new workflow. I tested it by forcing a nightly build (didn't let it complete tho, can if folks want). See the login successful here: https://app.circleci.com/pipelines/github/facebookresearch/habitat-sim/8237/workflows/cc8e9b97-c129-4eef-b84c-20b28b6339f9/jobs/44546How Has This Been Tested
Via the CI.
Types of changes
Bug fix (non-breaking change which fixes an issue)