Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda mutex #1541

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Conda mutex #1541

merged 3 commits into from
Oct 22, 2021

Conversation

erikwijmans
Copy link
Contributor

@erikwijmans erikwijmans commented Oct 20, 2021

Motivation and Context

We should use a mutex package instead of track features to support mamba.

If this looks good ill upload the mutex packages and updated feature packages to aihabitat and aihabitat-nightly (the new feature packages are backwards compatible)

Closes #1539

How Has This Been Tested

On MacOS, the following all get the right package

mamba/conda create -n hsim-mutex-test python=3.7 habitat-sim -c conda-forge -c erikwijmans
mamba/conda create -n hsim-mutex-test python=3.7 withbullet habitat-sim -c conda-forge -c erikwijmans
mamba/conda create -n hsim-mutex-test python=3.7 headless habitat-sim -c conda-forge -c erikwijmans
mamba/conda create -n hsim-mutex-test python=3.7 headless withbullet habitat-sim -c conda-forge -c erikwijmans

(I only did osx and those aren't real packages, just dummies to test with, so don't try on not osx or actually try to use them)

Types of changes

Docs change / refactoring / dependency upgrade

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 20, 2021
@@ -1,8 +1,12 @@
package:
name: withbullet
version: 1.0
version: 2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck, our yaml versioning doesn't match, but oh well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that it doesn't match with the simulator version? I think that's fine. These are feature tracking(/mutex deciding? no idea what to call them now) and don't match up with any version of habitat-sim.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, as long as they don't match with any version of HabSim, it's fine.

@Skylion007
Copy link
Contributor

While we are at it. our updated conda-build script complains about a lot of unnecessary requirements. We may want to remove them. It also recommends running conda-verify against our built packages, which we do not currently do.

@erikwijmans
Copy link
Contributor Author

I don't have the cycles to debug removing packages and conda warns that users don't need python to run our package so it's not a simple as just following what it says. I'm unfamiliar with conda-verify, but I assume it's suggestions too needs manual verification.

@Skylion007
Copy link
Contributor

Just merge it as is then.

@erikwijmans erikwijmans merged commit 222d2f2 into main Oct 22, 2021
@erikwijmans erikwijmans deleted the conda-mutex branch October 22, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install doesn't currently work with mamba
3 participants