-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda mutex #1541
Conda mutex #1541
Conversation
@@ -1,8 +1,12 @@ | |||
package: | |||
name: withbullet | |||
version: 1.0 | |||
version: 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yuck, our yaml versioning doesn't match, but oh well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that it doesn't match with the simulator version? I think that's fine. These are feature tracking(/mutex deciding? no idea what to call them now) and don't match up with any version of habitat-sim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, as long as they don't match with any version of HabSim, it's fine.
While we are at it. our updated conda-build script complains about a lot of unnecessary requirements. We may want to remove them. It also recommends running conda-verify against our built packages, which we do not currently do. |
I don't have the cycles to debug removing packages and conda warns that users don't need python to run our package so it's not a simple as just following what it says. I'm unfamiliar with conda-verify, but I assume it's suggestions too needs manual verification. |
Just merge it as is then. |
Motivation and Context
We should use a mutex package instead of track features to support mamba.
If this looks good ill upload the mutex packages and updated feature packages to aihabitat and aihabitat-nightly (the new feature packages are backwards compatible)
Closes #1539
How Has This Been Tested
On MacOS, the following all get the right package
(I only did osx and those aren't real packages, just dummies to test with, so don't try on not osx or actually try to use them)
Types of changes
Docs change / refactoring / dependency upgrade