Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]--Fix CatmullRom Traj off-by-ones; add multiple colorspaces gradient support #1571

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR fixes a couple bugs with the CR spline trajectory tube calc. The precalculated distances to be used as knot values were being accessed off-by-one, and the time interpolant itself was never reaching t2.

This PR also introduces support for other color spaces to traverse for the trajectory gradient.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 18, 2021
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the rapid fix.

@jturner65 jturner65 merged commit f8fd41a into facebookresearch:main Nov 18, 2021
@jturner65 jturner65 deleted the Bugfix_CR_Traj branch November 18, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants