Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix]--fix missing slots declarations of pimpl implementation refs. #1610

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[Bugfix]--fix missing slots declarations of pimpl implementation refs. #1610

merged 1 commit into from
Jan 4, 2022

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This small PR addresses the missing slot declarations for pimpl refs in sensor models.

How Has This Been Tested

Locally python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 3, 2022
@jturner65
Copy link
Contributor Author

The python lint unreachable code complaints are artifacts of this bug with the newest version of mypy

@jturner65 jturner65 requested a review from aclegg3 January 3, 2022 19:17
@jturner65 jturner65 merged commit 11254eb into facebookresearch:main Jan 4, 2022
@jturner65 jturner65 deleted the Py_SensorSlotsBugfix branch January 4, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jturner65 @Skylion007 @facebook-github-bot